[PATCH] D77925: Revert "[TLI] Per-function fveclib for math library used for vectorization"

Teresa Johnson via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sat May 2 09:31:30 PDT 2020


tejohnson added a comment.

In D77925#2016299 <https://reviews.llvm.org/D77925#2016299>, @wenlei wrote:

> @mehdi_amini @tejohnson When can we re-land this (with tweaks)? I'm under the impression that a test case demonstrating the 3rd party usage will be added very soon after this revert, then we can tweak the original patch to accommodate that usage, and re-land asap. Or am I missing something there? I'd like to get this unblocked asap. Currently we have to keep this as a private patch on our end which is a bit cumbersome, and I think this one can be useful for others too. Thanks..


@bkramer can you work with Wenlei on this (original patch is D77632 <https://reviews.llvm.org/D77632>).

@wenlei, in the meantime you can see the use case here:
https://github.com/tensorflow/tensorflow/blob/master/tensorflow/compiler/xla/service/cpu/compiler_functor.cc#L198
for revising the patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77925/new/

https://reviews.llvm.org/D77925





More information about the cfe-commits mailing list