[PATCH] D79106: [clangd] Move inserted include from detail -> documentation.

Haojian Wu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Apr 30 05:04:55 PDT 2020


hokein accepted this revision.
hokein added inline comments.
This revision is now accepted and ready to land.


================
Comment at: clang-tools-extra/clangd/CodeComplete.cpp:1834
   if (InsertInclude)
-    LSP.detail += "\n" + InsertInclude->Header;
-  LSP.documentation = Documentation;
+    LSP.documentation = llvm::formatv("#include {0}", InsertInclude->Header);
+  if (!Documentation.empty()) {
----------------
`#include` => `From`, IIUC discussion from the chat.

maybe worth a comment explaining why we make such a decision, the description seems good enough.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79106/new/

https://reviews.llvm.org/D79106





More information about the cfe-commits mailing list