[PATCH] D79085: [clangd] Add CMake dependencies for Protobuf-generated files

Kirill Bobyrev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Apr 29 07:28:26 PDT 2020


kbobyrev updated this revision to Diff 260906.
kbobyrev marked 2 inline comments as done.
kbobyrev added a comment.

Use DEPENDS instead of add_dependencies.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79085/new/

https://reviews.llvm.org/D79085

Files:
  clang-tools-extra/clangd/index/remote/CMakeLists.txt
  clang-tools-extra/clangd/index/remote/marshalling/CMakeLists.txt
  clang-tools-extra/clangd/index/remote/server/CMakeLists.txt


Index: clang-tools-extra/clangd/index/remote/server/CMakeLists.txt
===================================================================
--- clang-tools-extra/clangd/index/remote/server/CMakeLists.txt
+++ clang-tools-extra/clangd/index/remote/server/CMakeLists.txt
@@ -4,6 +4,9 @@
   )
 add_clang_executable(clangd-index-server
   Server.cpp
+
+  DEPENDS
+  RemoteIndexProtos
   )
 target_link_libraries(clangd-index-server
   PRIVATE
Index: clang-tools-extra/clangd/index/remote/marshalling/CMakeLists.txt
===================================================================
--- clang-tools-extra/clangd/index/remote/marshalling/CMakeLists.txt
+++ clang-tools-extra/clangd/index/remote/marshalling/CMakeLists.txt
@@ -6,4 +6,7 @@
 
   protobuf
   clangDaemon
+
+  DEPENDS
+  RemoteIndexProtos
   )
Index: clang-tools-extra/clangd/index/remote/CMakeLists.txt
===================================================================
--- clang-tools-extra/clangd/index/remote/CMakeLists.txt
+++ clang-tools-extra/clangd/index/remote/CMakeLists.txt
@@ -18,6 +18,9 @@
     protobuf
     grpc++
     clangDaemon
+
+    DEPENDS
+    RemoteIndexProtos
     )
 
   add_subdirectory(marshalling)


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D79085.260906.patch
Type: text/x-patch
Size: 1178 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20200429/44b1f9a2/attachment.bin>


More information about the cfe-commits mailing list