[PATCH] D78677: [SveEmitter] Add builtins for gather prefetches

Sander de Smalen via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Apr 29 04:15:23 PDT 2020


sdesmalen marked an inline comment as done.
sdesmalen added a comment.

Thanks for reviewing!



================
Comment at: clang/lib/CodeGen/CGBuiltin.cpp:7739
+
+    // Index needs to be passed as scaled offset.
+    llvm::Type *MemEltTy = SVEBuiltinMemEltTy(TypeFlags);
----------------
efriedma wrote:
> `} else {`, so you aren't multiplying by zero?
Good catch, I've fixed that before committing.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78677/new/

https://reviews.llvm.org/D78677





More information about the cfe-commits mailing list