[PATCH] D78995: [SveEmitter] NFCI: Describe splat operands like any other modifier

Sjoerd Meijer via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Apr 28 06:56:31 PDT 2020


SjoerdMeijer added inline comments.


================
Comment at: clang/utils/TableGen/SveEmitter.cpp:68
   TypeSpec TS;
+  bool IsSplat;
   bool Float, Signed, Immediate, Void, Constant, Pointer;
----------------
I was wondering if IsSplat belongs here or somewhere else. It doesn't sound like a type, like the other members do, but more a specific case of a vector? But saying this off the top of my head, haven't looked at the code and the context, but perhaps you can comment on this if this is where it should be or not.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78995/new/

https://reviews.llvm.org/D78995





More information about the cfe-commits mailing list