[PATCH] D76801: [AST] Print a<b<c>> without extra spaces in C++11 or later.

Adrian McCarthy via cfe-commits cfe-commits at lists.llvm.org
Sat Apr 25 09:51:03 PDT 2020


I completed the bisect, and it is indeed the change in spacing between the
`>`s that triggers the problem with the visualizers.

That said, I'm still suspicious that the std::map visualizer isn't quite
right with how it uses the wild cards and the template parameter
placeholder(s), but I don't think fixing that makes up for the fact that VS
expects the spaces.

On Thu, Apr 23, 2020 at 11:21 AM Reid Kleckner via Phabricator <
reviews at reviews.llvm.org> wrote:

> rnk added a comment.
>
> Thanks David, I'm comfortable with that stance for DWARF.
>
> I know @amccarth is looking into the recent VS visualizer issue, and I
> would like him to confirm if it was this change or not when he gets a
> chance.
>
>
> Repository:
>   rG LLVM Github Monorepo
>
> CHANGES SINCE LAST ACTION
>   https://reviews.llvm.org/D76801/new/
>
> https://reviews.llvm.org/D76801
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20200425/dadaf1ba/attachment.html>


More information about the cfe-commits mailing list