[PATCH] D78785: Fix x86/x86_64 calling convention for _ExtInt

John McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Apr 24 10:16:11 PDT 2020


rjmccall added a comment.

Is there something currently restricting these types to just x86, or do you need to do a much broader audit?



================
Comment at: clang/lib/CodeGen/TargetInfo.cpp:2980
 
-    return (Ty->isPromotableIntegerType() ? ABIArgInfo::getExtend(Ty)
-                                          : ABIArgInfo::getDirect());
+    if (!Ty->isExtIntType())
+      return (Ty->isPromotableIntegerType() ? ABIArgInfo::getExtend(Ty)
----------------
Presumably *some* `ExtInt` types should be returned directly.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78785/new/

https://reviews.llvm.org/D78785





More information about the cfe-commits mailing list