[PATCH] D70416: [Driver] Make -static-libgcc imply static libunwind

Idar Tollefsen via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Apr 23 16:20:19 PDT 2020


itollefsen added a comment.

This fails to account for whether you actually //have// the shared and/or static version of the library.



================
Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:1215
+    else
+      CmdArgs.push_back("-l:libunwind.so");
     break;
----------------
If you are building with `-DLIBUNWIND_ENABLE_SHARED:OFF -DLIBUNWIND_ENABLE_STATIC:ON`, there's no shared version available. And vice versa. This doesn't account for that.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70416/new/

https://reviews.llvm.org/D70416





More information about the cfe-commits mailing list