[PATCH] D78704: [analyzer][NFC] Add unittest for FalsePositiveRefutationBRVisitor

Gabor Marton via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Apr 23 07:32:18 PDT 2020


martong added inline comments.


================
Comment at: clang/unittests/StaticAnalyzer/FalsePositiveRefutationBRVisitorTest.cpp:65
+
+  bool reportIfCanBeZero(const CallEvent &Call, CheckerContext &C,
+                         ProgramStateRef State) const {
----------------
xazax.hun wrote:
> Maybe `reportIfArgCanBeZero`?
Perhaps a generic `reportIfTrue` would be more useful. For that you must use another eval function instead of `evalEQ`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78704/new/

https://reviews.llvm.org/D78704





More information about the cfe-commits mailing list