[PATCH] D46472: [HIP] Support offloading by linker script

Jon Chesterfield via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Apr 23 07:32:11 PDT 2020


JonChesterfield added inline comments.
Herald added a reviewer: jdoerfert.


================
Comment at: cfe/trunk/lib/Driver/ToolChains/CommonArgs.cpp:1329
+  // Get the HIP offload tool chain.
+  auto *HIPTC = static_cast<const toolchains::CudaToolChain *>(
+      C.getSingleOffloadToolChain<Action::OFK_HIP>());
----------------
Should this be `toolchains::HipToolChain`?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D46472/new/

https://reviews.llvm.org/D46472





More information about the cfe-commits mailing list