[PATCH] D78511: [Driver][doc] Document option -mtune as a no-op. NFC.

Arthur O'Dwyer via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Apr 20 13:00:17 PDT 2020


Quuxplusone added inline comments.


================
Comment at: clang/docs/ClangCommandLineReference.rst:2738
 
+Accepts any value for compatability reasons with GCC, thus not performing any CPU type specific tuning.
+
----------------
"Accepts any value, for compatibility with GCC. Does not perform any CPU-specific tuning."

In email I said:
> there is no practical difference, but there may be a psychological difference, between saying "Clang permanently treats -mtune as a no-op" versus "Clang has a remarkably low //quality of implementation// for -mtune, and has no immediate plans to either improve or regress it."

To me, this patch's wording implies that Clang is promising to keep -mtune as a no-op forever. If Bob puts `-mtune=supercalifragilistic` in his Makefile today, and then in the future Clang starts emitting an "unknown target" error, will Bob point to this documentation as evidence that Clang promised to accept `-mtune=supercalifragilistic` as a no-op?

So I would rather say:

"Accepted for compatibility with GCC. Currently has no effect."


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78511/new/

https://reviews.llvm.org/D78511





More information about the cfe-commits mailing list