[PATCH] D76801: [AST] Print a<b<c>> without extra spaces in C++11 or later.

Fri Apr 17 14:37:25 PDT 2020

sammccall added a comment.

In D76801#1989718 <https://reviews.llvm.org/D76801#1989718>, @rnk wrote:

> Hang on, I may have been too quick. We *do* have a test for this, at the end of clang/test/CodeGenCXX/debug-info-codeview-display-names.cpp:
>  https://github.com/llvm/llvm-project/blob/f8452ddfcc3336e42544a35481507f0b3bae423e/clang/test/CodeGenCXX/debug-info-codeview-display-name.cpp#L98
>
> The test passes for me locally, although I'm not sure why.

After this patch the default depends on the language version, and that test specifies c++98 :-(

> I would leave things a bit longer to give @amccarth more time to investigate and confirm. Thanks for the offer to help, though.

Sure thing, let me know if it's useful for me to pick this up. I'm sure the debugging was the worst of it though, sorry.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76801/new/

https://reviews.llvm.org/D76801