[PATCH] D76801: [AST] Print a<b<c>> without extra spaces in C++11 or later.

[Reid Kleckner via Phabricator via cfe-commits]

rnk added subscribers: tstellar, hans, rnk.
rnk added a comment.

We ran into three distinct issues with this change.

We updated the compiler and break some VS std::map visualizers:
https://crbug.com/1068394
I haven't 100% confirmed that this caused the issue, but looking at the code suggests that the names in our codeview output changed, which I would consider to be a regression. This should've been caught by clang's test suite. We already have codeview tests that try to ensure clang prints debug info names following MSVC's exact spacing, but apparently none broke, so this area was under-tested. I wonder if gdb or other DWARF consumers might be affected by this formatting change.

Two issues in the Chrome codebase where tests relied on the output of clang's diagnostics:
https://crbug.com/1064986
The compiler's diagnostic output isn't stable, so this is expected.

While I appreciate the effort towards modernization, I want to register that it has created work for folks, and this might come up again in six months during the next release. @tstellar @hans


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76801/new/

https://reviews.llvm.org/D76801