[PATCH] D77233: [NFC] Refactoring PropertyAttributeKind for ObjCPropertyDecl and ObjCDeclSpec.

Puyan Lotfi via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Apr 17 11:53:41 PDT 2020


plotfi added a comment.

In D77233#1977671 <https://reviews.llvm.org/D77233#1977671>, @erik.pilkington wrote:

> LGTM (after fixing those tests). Thanks for cleaning this up!


Can this be a LGTM again  @erik.pilkington @arphaman? I have managed to undo any unintended C API changes. Tests appear to all pass too. I had to add a short prefix to the enum values to avoid hitting any C++ keywords (ie class). Is there anything else needed for this refactor to go in?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77233/new/

https://reviews.llvm.org/D77233





More information about the cfe-commits mailing list