[PATCH] D73967: Implement _ExtInt as an extended int type specifier.

[Keane, Erich via cfe-commits]

No problem, thanks for the response!

Phab emails are apparently about 30 minutes delayed for me apparently, which is unfortunate or I would have had the fix ready before your revert 😊

Let me know if you run into any more issues, but I’m 99% sure I got it right this time.

Thanks
-Erich

From: Sterling Augustine <saugustine at google.com>
Sent: Friday, April 17, 2020 11:38 AM
To: reviews+D73967+public+2549cbb9adffa7d2 at reviews.llvm.org
Cc: Keane, Erich <erich.keane at intel.com>; aaron.ballman at gmail.com; M.Gehre at gmx.de; Blower, Melanie I <melanie.blower at intel.com>; Mikhail Ramalho <mikhail.ramalho at gmail.com>; arichardson.kde at gmail.com; david.green at arm.com; bevin.hansson at ericsson.com; riccibrun at gmail.com; Andrews, Elizabeth <elizabeth.andrews at intel.com>; sammhho at gmail.com; Mikael Holmén <mikael.holmen at ericsson.com>; a.bataev at hotmail.com; Sidorov, Dmitry <dmitry.sidorov at intel.com>; sabre+phabricator at nondot.org; karl-johan.karlsson at ericsson.com; github at john.mcfarlane.name; jfbastien at apple.com; ronan-list at keryell.fr; Richard Smith <richard at metafoo.co.uk>; ikosarev at accesssoftek.com; rekanikolett at gmail.com; Alex L <arphaman at gmail.com>; cfe-commits <cfe-commits at lists.llvm.org>; mlekena at skidmore.edu; blitzrakete at gmail.com; Han Shen <shenhan at google.com>; 1.int32 at gmail.com
Subject: Re: [PATCH] D73967: Implement _ExtInt as an extended int type specifier.

Sorry for the trouble. I think many buildbots don't build lldb--not enough of them anyway. I found this myself.

As I understand it, the switch-cover warning is supposed to be enabled everywhere when built in release mode, so it looks like the lldb builders (what few there are) aren't building in release mode. I can look into fixing that.

On Fri, Apr 17, 2020 at 11:20 AM Erich Keane via Phabricator <reviews at reviews.llvm.org<mailto:reviews at reviews.llvm.org>> wrote:
erichkeane added a comment.

Already relanded here: 5f0903e9bec9 <https://reviews.llvm.org/rG5f0903e9bec97e67bf34d887bcbe9d05790de934>

@saugustine  I checked the buildbots, every one with LLDB in its name stayed green, and I cannot see the warning in any of their STDIO.  Can you point out how I can proactively keep an eye on this? The lldb build is broken out-of-the-box anyway for me due to the LLDB Python Wrapper having a syntax error in the SWIG bindings.

bash-4.2$ swig -copyright

SWIG Version 2.0.10
/workspaces/llvm-project/lldb/bindings/./python/python-typemaps.swig:496: Error: Syntax error in input(3).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73967/new/

https://reviews.llvm.org/D73967


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20200417/afeeda01/attachment-0001.html>