[PATCH] D78323: [clang] Fix invalid comparator in tablegen

Eric Fiselier via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Apr 16 15:37:59 PDT 2020


EricWF added a comment.

In D78323#1987596 <https://reviews.llvm.org/D78323#1987596>, @sdesmalen wrote:

> LGTM, did this comparison introduce any non-determinism?


Potentially, but I observed the issue using libc++'s debug mode.
I'm unsure if the current inputs would have caused libc++ to read past the end of the vector.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78323/new/

https://reviews.llvm.org/D78323





More information about the cfe-commits mailing list