[PATCH] D78189: [analyzer] StdLibraryFunctionsChecker: Add statistics

[Balázs Kéri via Phabricator via cfe-commits]

balazske added inline comments.


================
Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:67
+#define DEBUG_TYPE "StdLibraryFunctionsChecker"
+STATISTIC(NumCall, "The # of calls handled by the checker");
+STATISTIC(NumFoundSummary, "The # of calls with associated summary");
----------------
This may be misleading: It is every call event that is encountered, even if not handled specially (because no summary). (I would not call a function "handled" if we do nothing with it beneath a check if it needs to be handled really.) Probably "found" is better.


================
Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:68
+STATISTIC(NumCall, "The # of calls handled by the checker");
+STATISTIC(NumFoundSummary, "The # of calls with associated summary");
+STATISTIC(NumArgConstraintViolated,
----------------
//The # of calls with summary// or //The # of handled calls with associated summary// ?
Probably only for me but I had difficulty to understand what this means.


================
Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:72
+STATISTIC(NumArgConstrained,
+          "The # of calls with applied argumentum constraints");
+STATISTIC(NumCaseApplied, "The # of calls with applied cases");
----------------
Change "argumentum" to "argument"?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78189/new/

https://reviews.llvm.org/D78189