[PATCH] D77880: get scan-view executable from environment

Oliver Tušla via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Apr 16 00:54:05 PDT 2020


asmar added a comment.

Rather than globbing I would check whether there's a `scan-view` directory with the same version suffix as in the `scan-build`'s one. Getting "random" version from other directories doesn't seem transparent to me. When this fails, `which` for the system version is expected behaviour I suppose.

I believe that Perl error is sufficient. It emits the correct error code, helps to spot the root of the error right away and custom error will not have any other benefits.

I am not sure about reporting `$PATH` though.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77880/new/

https://reviews.llvm.org/D77880





More information about the cfe-commits mailing list