[PATCH] D78139: [clang-tidy] modernize-use-using: Fix broken fixit with 'template' keyword

Nathan James via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Apr 15 04:20:34 PDT 2020


njames93 added inline comments.


================
Comment at: clang/lib/AST/NestedNameSpecifier.cpp:314
+                                InnerPolicy);
+    } else if (const auto *SpecType =
+                   dyn_cast<DependentTemplateSpecializationType>(T)) {
----------------
Can this be renamed as it shadows the `SpecType` variable from line 305, maybe `DepSpecType`.


================
Comment at: clang/lib/AST/TypePrinter.cpp:1391-1392
     T->getQualifier()->print(OS, Policy);
+  OS << "template ";
   OS << T->getIdentifier()->getName();
   printTemplateArgumentList(OS, T->template_arguments(), Policy);
----------------
This can be merged to one statement.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78139/new/

https://reviews.llvm.org/D78139





More information about the cfe-commits mailing list