[PATCH] D78066: [SemaObjC] Forbid storing an unboxed integer literal in an NSNumber

Erik Pilkington via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Apr 13 17:25:08 PDT 2020


erik.pilkington created this revision.
erik.pilkington added reviewers: rjmccall, bendjones, arphaman.
Herald added subscribers: ributzka, dexonsmith, jkorous.

This fixes a common mistake (the 3 should be @3): `NSNumber *n = 3`. This extends an existing check for NSString. Also, this only errs if the initializer isn't a null pointer constant, so `NSNumber *n = 0;` continues to work.

Fixes rdar://47029572


Repository:
  rC Clang

https://reviews.llvm.org/D78066

Files:
  clang/include/clang/Basic/DiagnosticSemaKinds.td
  clang/include/clang/Sema/Sema.h
  clang/lib/Sema/SemaExpr.cpp
  clang/lib/Sema/SemaExprObjC.cpp
  clang/lib/Sema/SemaInit.cpp
  clang/test/SemaObjC/objc-literal-fixit.m

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D78066.257157.patch
Type: text/x-patch
Size: 8040 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20200414/6a6d674d/attachment.bin>


More information about the cfe-commits mailing list