[PATCH] D74387: [SYCL] Defer __float128 type usage diagnostics

Mariya Podchishchaeva via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Apr 13 11:18:02 PDT 2020


Fznamznon added a comment.

In D74387#1974981 <https://reviews.llvm.org/D74387#1974981>, @jdoerfert wrote:

> As I mentioned before. As long as the type is not "used" you can treat it as a sequence of bytes just as well. So we can lower `__float128` to `char [16]` with the right alignment. SPIRV will never see unsupported types and the code works because we never access it as `float128` anyway. WDYT?


Yes, it can work for SYCL without additional diagnostics if it is possible to replace `__float128` with `char [16]` everywhere (including struct definitions and so on) in the resulting LLVM IR module.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74387/new/

https://reviews.llvm.org/D74387





More information about the cfe-commits mailing list