[PATCH] D77962: PR38490: Support reading values out of __uuidof(X) expressions during constant evaluation.

Arthur Eubanks via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Apr 13 10:44:58 PDT 2020


aeubanks added inline comments.


================
Comment at: clang/lib/AST/ExprConstant.cpp:3949
+      // Special-case reading from __uuidof expressions so we don't have to
+      // construct an APValue for the whole uuid.
+      if (LVal.Designator.isOnePastTheEnd()) {
----------------
For my knowledge, why try to avoid constructing an APValue for the whole uuid? Is special casing this necessary?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77962/new/

https://reviews.llvm.org/D77962





More information about the cfe-commits mailing list