[PATCH] D78000: [ASTImporter] Fix handling of not defined FromRecord in ImportContext(...)

Shafik Yaghmour via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sun Apr 12 22:27:32 PDT 2020


shafik added a comment.

I am open to different approaches to this problem, this is opening attempt at fixing it but I may be missing other interactions.

AFAICT starting the definition of `ToRecord` the way  `CompleteDecl(…)`  does when we know `FromRecord` is not defined is just broken for the `RecordDecl` case if we have bases.

It took me a lot of time to come up with this reproducer from a real life issue debugging `llc`.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78000/new/

https://reviews.llvm.org/D78000





More information about the cfe-commits mailing list