[PATCH] D77952: [TLII] Reduce copies of TLII for TLA

Teresa Johnson via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sun Apr 12 14:57:20 PDT 2020


tejohnson added a comment.

lgtm with the VecLibDesc references removed.



================
Comment at: llvm/lib/Analysis/TargetLibraryInfo.cpp:596
   memcpy(AvailableArray, TLI.AvailableArray, sizeof(AvailableArray));
   return *this;
 }
----------------
wenlei wrote:
> tejohnson wrote:
> > This is missing copying of the VecLibDescs (looks like I missed this as well originally).
> Now I remembered why this was missed from my side, before my patch, `VecLibDescs` isn't copied here either, which seems like a bug? Same for the move one below. 
I assume you mean the VectorDescs/ScalarDescs vectors. You are right, even before your D77632 patch they were not being copied here or below. Looks like there is an existing bug there that no one noticed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77952/new/

https://reviews.llvm.org/D77952





More information about the cfe-commits mailing list