[PATCH] D77952: [TLI] Reduce copies for TLI and TLA

Sat Apr 11 16:00:19 PDT 2020

wenlei marked an inline comment as done.
wenlei added a comment.

In D77952#1976336 <https://reviews.llvm.org/D77952#1976336>, @tejohnson wrote:

> Some parts of this are dependent on the patch that got reverted, but I have some other questions below about the changes in BackendUtil.cpp.

Thanks for quick review.. I will remove the changes dependent on the reverted change before commit.

================
Comment at: clang/lib/CodeGen/BackendUtil.cpp:689
   // Set up the per-function pass manager.
-  FPM.add(new TargetLibraryInfoWrapperPass(*TLII));
+  FPM.add(new TargetLibraryInfoWrapperPass(TargetTriple));
   if (CodeGenOpts.VerifyModule)
----------------
tejohnson wrote:
> These changes mean we now construct a new TLII multiple times (e.g. both when we add the TargetLibraryInfoWrapperPass to the MPM earlier and to the FPM here, rather that just copying. Is this actually faster? It seems like it would be slower overall.
Oops, this one isn't intentional... changed it back. Though for other instances where TLII isn't reused, similar change turns extra copy into move.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77952/new/

https://reviews.llvm.org/D77952