[PATCH] D77632: [TLI] Per-function fveclib for math library used for vectorization

Teresa Johnson via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Apr 9 16:21:40 PDT 2020


tejohnson accepted this revision.
tejohnson added a comment.
This revision is now accepted and ready to land.

lgtm. I think one check is missing in the test, see comment below.



================
Comment at: llvm/test/Transforms/Inline/veclib-compat.ll:28
+  %rslt = call i32 @callee_massv(i8 123)
+; SUPERSET: call i32 @callee_massv
+  %tmp1 = call i32 @callee_nolibrary(i8 123)
----------------
I think NOSUPERSET should also check that there is still a call here. You can probably replace some of the duplicated checks with COMMON in this function too.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77632/new/

https://reviews.llvm.org/D77632





More information about the cfe-commits mailing list