[PATCH] D77777: [nvptx] Add `nvvm.texsurf.handle` internalizer.

Artem Belevich via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Apr 9 10:45:40 PDT 2020


tra added a comment.

The patch could use a more detailed description. Specifically, it does not describe the purpose of these changes.

> Replace them with the internal version, i.e. nvvm.texsurf.handle.internal just before the instruction selector.

It's not clear what is 'them'. 'nvvm.texsurf.handle' ?
If so, do we need 'internal' any more? Can we just rename internal and be done with it? Adding an extra pass just to replace one intrinsic with another seems to be unnecessary.

I may be missing something here. Why do we have internal and non-internal intrinsics at all? Do we need both?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77777/new/

https://reviews.llvm.org/D77777





More information about the cfe-commits mailing list