[PATCH] D77628: [Driver][X86] Add -mpad-max-prefix-size

[Kan Shengchen via Phabricator via cfe-commits]

skan added a comment.



In D77628#1969856 <https://reviews.llvm.org/D77628#1969856>, @MaskRay wrote:

> This looks like it requires more thorough discussions, doesn't it? We will also need discussions with the binutils side. We requested a GCC compiler driver option long ago but we do not reach a consensus (https://gcc.gnu.org/legacy-ml/gcc/2020-01/msg00358.html). IMHO the approval was in haste. With all due respect, I think I've seen such hasty approval (without any mentioning why such decisions are justifiable) and hasty commits in this area before several times, so I'll click "Request Changes" just in case of an accidental commit.


AFAICS, this patch adds `-mpad-max-prefix-size` for clang, I mentioned `-malign-branch-prefix-size` in the summary just to clarify it has different behaviour from GAS's option `-malign-branch-prefix-size`.  This patch has nothing to do with GCC compatibility, so I think the reasons for objection are not sufficient.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77628/new/

https://reviews.llvm.org/D77628