[PATCH] D77743: [HIP] Emit symbols with kernel name in host binary

Yaxun Liu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Apr 8 12:30:31 PDT 2020


yaxunl added a comment.

In D77743#1970035 <https://reviews.llvm.org/D77743#1970035>, @tra wrote:

> Would not this scheme create a conflict between the device-side mangled kernel name and the handle which we emit with the same name? I recall that the distinct stub name was introduced specifically to avoid confusion between device-side kernel and the host-side stub that were visible at the same time (to debugger only?). Now we seen to re-introduce the same name only for the host-side handle instead of the host-side stub.


we need the stub name to be different than the kernel name because otherwise the debugger will break on the stub function when the users put a break point on the kernel.

The kernel handle is a variable. Even if it has the same name as kernel, it is OK for the debugger since the debugger does not put break point on a variable.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77743/new/

https://reviews.llvm.org/D77743





More information about the cfe-commits mailing list