[PATCH] D77641: [analyzer] StdLibraryFunctionsChecker: Associate summaries to FunctionDecls

Gabor Marton via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Apr 8 09:12:53 PDT 2020


martong added a comment.

In D77641#1969412 <https://reviews.llvm.org/D77641#1969412>, @NoQ wrote:

> So you only do the lookup in the global scope? What about `namespace std`?
>
> Do you also plan to support class methods by looking up the class first and then looking up the method in the class?


Yes, I had been planning with those. When it comes to the point where we'd like to add summaries for C++ functions (in namespaces or member functions) then we can add a new overloaded `operator()` to `AddToFunctionSummaryMap`. In this new function we could handle a fully qualified name (e.g. `std::map::insert`) by doing the lookup in each found `DeclContext` starting from the `TranslationUnitDecl`. (Naturally, we'd not support ADL or `using` declaration kind of lookup modifications, only fully qualified names would be allowed.) Note that we could give a summary only to those functions that can be found by qualified [Obj]C/C++ lookup. So, e.g. functions in unnamed namespaces or in-class defined friend functions are out of this game.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77641/new/

https://reviews.llvm.org/D77641





More information about the cfe-commits mailing list