[PATCH] D77665: [CUDA] Simplify GPU variant handling. NFC.

Artem Belevich via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Apr 7 12:31:57 PDT 2020


tra marked an inline comment as done.
tra added inline comments.


================
Comment at: clang/lib/Basic/Cuda.cpp:61
+    // clang-format off
+    SM2(20, "compute_20"), SM2(21, "compute_20"), // Fermi
+    SM(30), SM(32), SM(35), SM(37),  // Kepler
----------------
yaxunl wrote:
> Thanks for the efforts. Really appreciate this.
> 
> Can we separate this part to a def file and include it here and also in enum class CudaArch? Then we only need to maintain the def file.
> 
> Thanks.
If we had similar per-GPU code in many places, then it would make a lot of sense.
At the moment I'm not sure it would be worth it -- I don't see any other code that would benefit, other than this file.



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77665/new/

https://reviews.llvm.org/D77665





More information about the cfe-commits mailing list