[PATCH] D77614: [Syntax] Simplify TokenCollector::Builder, use captured expansion bounds. NFC

Sam McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Apr 7 02:40:27 PDT 2020


sammccall updated this revision to Diff 255618.
sammccall added a comment.

Crash with a nice message if our loop gets stuck.

Looks like

  ok Token(`void`, void, length = 4)
  ok Token(`test`, identifier, length = 4)
  ok Token(`(`, l_paren, length = 1)
  ok Token(`int`, int, length = 3)
  ok Token(`*`, star, length = 1)
  ok Token(`List`, identifier, length = 4)
  ok Token(`)`, r_paren, length = 1)
  ok Token(`{`, l_brace, length = 1)
  ok Token(`0`, numeric_constant, length = 1)
  !! Token(``, eof, length = 0)
     Token(`}`, r_brace, length = 1)
     Token(``, eof, length = 0)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77614/new/

https://reviews.llvm.org/D77614

Files:
  clang/lib/Tooling/Syntax/Tokens.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D77614.255618.patch
Type: text/x-patch
Size: 14371 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20200407/d3d054c8/attachment-0001.bin>


More information about the cfe-commits mailing list