[PATCH] D75682: [Analyzer][StreamChecker] Introduction of stream error handling.

Mon Apr 6 12:30:53 PDT 2020

Szelethus added inline comments.

================
Comment at: clang/include/clang/StaticAnalyzer/Checkers/Checkers.td:455

+def StreamTesterChecker : Checker<"StreamTester">,
+  HelpText<"Add test functions to StreamChecker for test and debugging purposes.">,
----------------
NoQ wrote:
> This should go into the debug package. We don't want users to enable it accidentally by enabling the whole `unix` package.
Oh, nice catch!

================
Comment at: clang/lib/StaticAnalyzer/Checkers/StreamChecker.cpp:26-28
+#define ASSERT_STREAMSTATE_OPENED                                              \
+  assert(SS->isOpened() &&                                                     \
+         "Create of error node failed (only way to get this state)?");
----------------
NoQ wrote:
> `assertStreamStateOpened(SS);` isn't much harder to type. Can we make it a function please?
Mind that this is completely stripped from release builds, unlike a function call. I think.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75682/new/

https://reviews.llvm.org/D75682