[PATCH] D77229: [Analyzer][WIP] Avoid handling of LazyCompundVals in IteratorModeling

Balogh, Ádám via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Apr 6 04:50:13 PDT 2020


baloghadamsoftware added a comment.

In D77229#1963485 <https://reviews.llvm.org/D77229#1963485>, @NoQ wrote:

> Uh-oh, it's annoying indeed that you can't easily obtain the current CFG element from inside a `CallEvent`.
>
> Given that every `CallEvent` is in fact associated with a `CFGElement` (but not every `CallEvent` is associated with an `Expr` or have a `Decl`), can we modify the `CallEvent` structure to store a `CFGElementRef` //instead// of `llvm::PointerUnion<const Expr *, const Decl *> Origin;`? That might be some work but it should increase our sanity by a lot.


Yes, that seems a good idea. For now I solved this problem, but storing something instead of searching for it linearily sound better in regards of performance. However my current problem is worse, I have no idea at all, how to solve it.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77229/new/

https://reviews.llvm.org/D77229





More information about the cfe-commits mailing list