[PATCH] D77534: [clangd] DefineOutline: removes static token from static CXXMethodDecl

Kadir Cetinkaya via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Apr 6 04:17:55 PDT 2020


kadircet added a comment.

thanks for the patch!

this is quite similar to handling `kw_virtual` even handling multiple `static` keywords. Could you rather factor the `search for kw, generate an edit to delete specifier` part into a `DelKeyword` lambda similar to `DelAttr` and call it with kw_static and kw_virtual?

p.s. you can make use of `tok::getKeywordSpelling` for error messages.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77534/new/

https://reviews.llvm.org/D77534





More information about the cfe-commits mailing list