[PATCH] D77290: [OpenMP] Specialize OpenMP calls after template instantiation

Johannes Doerfert via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sun Apr 5 20:49:16 PDT 2020


jdoerfert marked an inline comment as done.
jdoerfert added inline comments.


================
Comment at: clang/lib/Sema/SemaTemplateInstantiate.cpp:1693
+ExprResult TemplateInstantiator::TransformCallExpr(CallExpr *E) {
+  ExprResult R = TreeTransform<TemplateInstantiator>::TransformCallExpr(E);
+  if (!SemaRef.getLangOpts().OpenMP || !R.isUsable() || !isa<CallExpr>(R.get()))
----------------
mikerice wrote:
> Is there a reason you are adding this here as opposed to in the base class RebuildCallExpr?  Are there cases where we rebuild call expressions that we don't want to do this variant processing?
I just didn't know about it. I'll move the code there.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77290/new/

https://reviews.llvm.org/D77290





More information about the cfe-commits mailing list