[PATCH] D68049: Propeller: Clang options for basic block sections

Sriraman Tallam via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Apr 3 21:06:59 PDT 2020


tmsriram added inline comments.


================
Comment at: clang/test/CodeGen/basicblock-sections.c:35
+//
+// BB_WORLD: .section .text.world,"ax", at progbits
+// BB_WORLD: world
----------------
MaskRay wrote:
> I haven't read through the previous threads whether we should use a .c -> .s test here. Assume we've decided to do that, `@progbits` should be followed by `{{$}}` to ensure there is no unique assembly linkage.
Fixed.  About .c->.s, this is similar to what function-sections.c does too. Please let me know if I missed anything.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68049/new/

https://reviews.llvm.org/D68049





More information about the cfe-commits mailing list