[PATCH] D77199: [clang-tidy] Address false positive in modernize-use-default-member-init

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Apr 3 09:41:11 PDT 2020


aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.

LGTM with a testing request.



================
Comment at: clang-tools-extra/test/clang-tidy/checkers/modernize-use-default-member-init.cpp:436
+
+struct PR45363 {
+  // Ensure no warning is emitted here
----------------
Can you add a test where the value is elided but braced init is still used:
```
struct PR45363 {
  PR45363() : m_i{} {} // This should still warn
  int m_i;
};
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77199/new/

https://reviews.llvm.org/D77199





More information about the cfe-commits mailing list