[PATCH] D77355: [clangd] show layout info when hovering on a class/field definition.

Sam McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Apr 3 06:57:46 PDT 2020


sammccall added inline comments.


================
Comment at: clang-tools-extra/clangd/unittests/HoverTests.cpp:69
             struct Foo {
-              int [[b^ar]];
+              char [[b^ar]];
             };
----------------
kadircet wrote:
> any reason for changing these from int to char ?
hardcoding sizeof(int) isn't portable unless we want to set the target explicitly


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77355/new/

https://reviews.llvm.org/D77355





More information about the cfe-commits mailing list