[PATCH] D76680: [SveEmitter] Add immediate checks for lanes and complex imms

Sander de Smalen via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Apr 3 06:57:43 PDT 2020


sdesmalen added a comment.

In D76680#1959217 <https://reviews.llvm.org/D76680#1959217>, @SjoerdMeijer wrote:

> Looks good to me, but just one question about the tests. If I haven't overlooked anything, I don't see tests that check the new diagnostics:
>  "argument should be the value 90 or 270"
>  "argument should be the value 0,90,180 or 270"
>
> Should they be here, or are they somewhere else?


Good point, I seem to have forgotten to add these tests. I'll update the patch!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76680/new/

https://reviews.llvm.org/D76680





More information about the cfe-commits mailing list