[PATCH] D75791: [clang-format] Added new option IndentExternBlock

MyDeveloperDay via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Apr 3 03:43:51 PDT 2020


MyDeveloperDay added a comment.



> Ok, I've got an idea to deprecate the AfterExternBlock option and map it to a new option

Really? can't you just model IndentExternBlock as an enum? then say

  bool shouldIndent = Style.IndentExternBlock==Indented ||
                                    ( AfterExternBlock && Style.IndentExternBlock==NotSpecified)
  
  parseBlock(/*MustBeDeclaration=*/true,
          /*AddLevel=*/shouldIndent);

You can even keep "true" and "false" the the enumeration marshaller and you don't even have to change the documentation.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75791/new/

https://reviews.llvm.org/D75791





More information about the cfe-commits mailing list