[PATCH] D77229: [Analyzer][WIP] Avoid handling of LazyCompundVals in IteratorModeling

Endre Fülöp via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Apr 3 02:07:24 PDT 2020


gamesh411 added inline comments.


================
Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/CallEvent.h:436
+  /// context from where the region of its return value can be retrieved.
+  const ConstructionContext *getConstructionContext(unsigned BlockCount) const;
+  
----------------
Maybe indicating wheter the call returns a C++ record type should be done via using and Optional here (to modernize the api)?


================
Comment at: clang/lib/StaticAnalyzer/Checkers/IteratorModeling.cpp:342
+    if (const auto *CC = Call.getConstructionContext(C.blockCount())) {
+      llvm::errs()<<"  Bingo!\n";
+      auto &Engine = C.getExprEngine();
----------------
Debug comment left here :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77229/new/

https://reviews.llvm.org/D77229





More information about the cfe-commits mailing list