[PATCH] D76238: [SveEmitter] Implement builtins for contiguous loads/stores

Sjoerd Meijer via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Apr 1 03:51:09 PDT 2020


SjoerdMeijer added a comment.

Thanks for the ping, hadn't noticed the updates.

I may have also missed why you need the SVE_ACLE_FUNC macro. Can you quickly comment why you need that? Just asking because in my opinion it doesn't really make it more pleasant to read (so it's there for another reason).

On one of the other tickets (may have missed a notification there too)  I asked why you need option `-fallow-half-arguments-and-returns`. Do you really need that, and why?

And last question is if you really need to pass these defines `-D__ARM_FEATURE_SVE`?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76238/new/

https://reviews.llvm.org/D76238





More information about the cfe-commits mailing list