[PATCH] D77074: [FPEnv][AArch64] Platform-specific builtin constrained FP enablement

[Diogo N. Sampaio via Phabricator via cfe-commits]

dnsampaio added inline comments.


================
Comment at: clang/test/CodeGen/aarch64-neon-intrinsics-constrained.c:288
+
+// XXX FIXME do we need to check for both w and x registers?
+// COMMON-LABEL: test_vceq_f64
----------------
kpn wrote:
> Anyone? I'm not an ARM expert.
The is variants of the `cset` instruction for both `w` and `x`. But I believe that for these tests it should be stable enough to accept only one of them.


================
Comment at: clang/test/CodeGen/aarch64-neon-intrinsics-constrained.c:889
+
+// FIXME why the unused bitcast? There are several of them!
+// COMMON-LABEL: test_vrnda_f64
----------------
kpn wrote:
> ???
It is a known issue. I believe no-one dug through the neon-emmiter machinery to find out why yet.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77074/new/

https://reviews.llvm.org/D77074