[PATCH] D77012: [analyzer] Fix StdLibraryFunctionsChecker NotNull Constraint Check

[Kristóf Umann via Phabricator via cfe-commits]

Szelethus added a comment.



In D77012#1948550 <https://reviews.llvm.org/D77012#1948550>, @NoQ wrote:

> @Szelethus can we make this checker depend on undefined value checker (probably CallAndMessage) so that uninitialized arguments were handled first?


I'll drop some pointers to previous discussions: D67336#1928925 <https://reviews.llvm.org/D67336#1928925>, D69662#1891124 <https://reviews.llvm.org/D69662#1891124>. I took a look, the evaluation order indeed depends on the order of registration, and the order of registration can be controlled with checker dependencies.

> In fact, can we make a silent assumption that everything depends on `core`? If so we could eliminate all checks for undefined values in PreStmt and PreCall.

I wouldn't be comfortable doing that before we can separate the modeling portions from the diagnostics.

[cfe-dev] [analyzer][RFC] Our stance on checker dependencies and disabling core checkers: http://lists.llvm.org/pipermail/cfe-dev/2019-August/063070.html


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77012/new/

https://reviews.llvm.org/D77012