[PATCH] D76922: [Syntax] Remove delayed folding from tree building.

Dmitri Gribenko via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Mar 30 07:33:18 PDT 2020


gribozavr2 accepted this revision.
gribozavr2 added a comment.
This revision is now accepted and ready to land.

Could you add the following tests?

  struct Point { int x, y; } point, *pointPtr;
  typedef struct Point { int x, y; } PointTy, *PointPtr;
  typedef struct { int x, y; } PointTy, *PointPtr;



================
Comment at: clang/lib/Tooling/Syntax/BuildTree.cpp:278
+
+    const auto *TD = llvm::dyn_cast<T>(D);
+    if (TD == nullptr) {
----------------
I think this cast should not be necessary -- `D` is already a `const T*`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76922/new/

https://reviews.llvm.org/D76922





More information about the cfe-commits mailing list