[PATCH] D76595: [clangd-vscode] NFC; Improve wording in documentation and update VSCode tasks

Haojian Wu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Mar 25 01:35:34 PDT 2020


hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.

In D76595#1938727 <https://reviews.llvm.org/D76595#1938727>, @kbobyrev wrote:

> In D76595#1936408 <https://reviews.llvm.org/D76595#1936408>, @hokein wrote:
>
> > thanks. regarding files in `.vscode`, I think they are just local configs in VSCode, we can probably remove the whole directory from git since we already ignore them in the `llvm/.gitignore`.
>
>
> I think those are hand-written VSCode tasks and removing those would result in the absence of compiling and debugging actions in VSCode. `llvm/.gitignore` is intended to ignore the configs, but I'm not sure it is a "config file" in traditional sensee. Am I missing something?


ah, I see. If removing these would cause troubles, then let's keep it (I thought these files are generated by VSCode as well).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76595/new/

https://reviews.llvm.org/D76595





More information about the cfe-commits mailing list