[PATCH] D74183: [IRGen] Add an alignment attribute to underaligned sret parameters

Eli Friedman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Mar 23 11:28:26 PDT 2020


efriedma added a comment.

I think we should remove the LangRef rule that says "sret" pointers have to be dereferenceable/naturally aligned, and let the frontend add explicit aligned/dereferenceable markings where appropriate.  (At that point, sret has no target-independent meaning; it's just to manipulate the target ABI.)  It would make the IR easier to understand, and resolves the interaction with opaque pointers.

That isn't to say we shouldn't make this change in clang; clang should do this, but at that point it would just be a performance enhancement, not required for correctness.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74183/new/

https://reviews.llvm.org/D74183





More information about the cfe-commits mailing list