[PATCH] D74619: [ARM] Enabling range checks on Neon intrinsics' lane arguments

Fri Mar 20 15:12:44 PDT 2020

leonardchan added a comment.

Hi, a bisect seems to show https://reviews.llvm.org/rGf56550cf7f12b581a237b48a7f4d8b6682d45a09 is causing us to see the following error:

  error: argument value 1 is outside the valid range [0, 0]
  v2 = vdupq_lane_f64(vget_high_f64(a.v), 1);
  ^                                  ~
  ../../prebuilt/third_party/clang/linux-x64/lib/clang/11.0.0/include/arm_neon.h:46503:15: note: expanded from macro 'vdupq_lane_f64'
  __ret_307 = splatq_lane_f64(__s0_307, __p1_307); \
  ^                         ~~~~~~~~
  ../../prebuilt/third_party/clang/linux-x64/lib/clang/11.0.0/include/arm_neon.h:680:25: note: expanded from macro 'splatq_lane_f64'
  __ret = (float64x2_t) __builtin_neon_splatq_lane_v((int8x8_t)__s0, __p1, 10); \
  ^                                            ~~~~
  1 error generated.

when building Fuchsia.

I'll see if I can make a minimal reproducer. Just wanted to raise awareness in the meantime to see if you can take a look.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74619/new/

https://reviews.llvm.org/D74619