[PATCH] D76396: Allow immediate invocation of constructors

Wyatt Childers via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Mar 19 10:17:59 PDT 2020


wchilders abandoned this revision.
wchilders added a comment.

In D76396#1930773 <https://reviews.llvm.org/D76396#1930773>, @Tyker wrote:

> I have already a patch aiming to do the same thing. D74007 <https://reviews.llvm.org/D74007>


Oof, okay, sounds good. I was not aware of this patch, it looks to be much further along :)

>> Provide improvements which allow the cached values of ConstantExpr to be used by both the constant evaluator and code gen
> 
> this is definitely something we should do.
> 
>> Update the application of evaluation contexts, using the stronger guarantees of manifest constant evaluation to apply the ConstantEvaluated evaluation context in more places
> 
> the tracking of evaluation context isn't as good as it could/should.

With this being closed out in favor of Tyker's patch, I'll post a patch for reusing cached values of ConstantExpr shortly.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76396/new/

https://reviews.llvm.org/D76396





More information about the cfe-commits mailing list